deps: update several things at once (sdk, cometbft, ibc-go, btcd) #2490
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
faddat
requested review from
alexanderbez,
yaruwangway,
crodriguezvega,
jackzampolin,
mmulji-ic,
glnro,
jtremback,
mpoke,
sainoe,
MSalopek and
shaspitz
as code owners
faddat
changed the title
5 tasks
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2490 +/- ##
==========================================
+ Coverage 84.99% 85.08% +0.09%
==========================================
Files 22 23 +1
Lines 1599 1596 -3
==========================================
- Hits 1359 1358 -1
+ Misses 193 192 -1
+ Partials 47 46 -1
|
shaspitz
approved these changes
May 17, 2023
|
hey @smarshall-spitzbart would you like to keep the update to v1.2.1 or should I change it? |
You should remove just the update to ICS, thank you |
18 tasks
18 tasks
|
Just out of curiosity, what's the difference? I'll go have a look 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates various libraries, and removes a few replace statements. These changes are intentionally grouped, because they will not work correctly independent of one another:
Once again, just to be as clear as possible: the dragonberry replace statement has not been needed for a long time. The latest version of comet will work best with the latest sdk, and same thing for ibc-go. So these changes have been grouped, and they should be grouped.
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!in the type prefix if API or client breaking change